Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use packed attribute in structs in cdvd_config.h #441

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Use packed attribute in structs in cdvd_config.h #441

merged 1 commit into from
Jun 20, 2021

Conversation

uyjulian
Copy link
Member

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

n32 and o32 ABIs have different alignment, so use packed attribute to ensure structures are same size.

@KrahJohlito KrahJohlito merged commit 770dd62 into ps2homebrew:master Jun 20, 2021
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
@KrahJohlito
Merge pull request #441 from uyjulian/packstruct
f18fc32 
Use packed attribute in structs in cdvd_config.h
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
@KrahJohlito
Merge pull request ps2homebrew#441 from uyjulian/packstruct
62ba241 
Use packed attribute in structs in cdvd_config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AKuHAK AKuHAK AKuHAK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uyjulian @AKuHAK @KrahJohlito